[JENKINS-74907] Add validations when Jenkins is in FIPS mode #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required to have access to jenkins.security.FIPS140
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
PereBueno
reviewed
Nov 26, 2024
|
I'm fixing the unit test |
Priya-CB
reviewed
Nov 26, 2024
fcojfernandez
changed the title
|
It's not possible to tests this because of non-compliant dependencies. So I'm moving this PR to draft. |
# Conflicts: # pom.xml # src/main/java/hudson/plugins/ec2/EC2Cloud.java # src/main/java/hudson/plugins/ec2/WindowsData.java # src/main/java/hudson/plugins/ec2/ssh/verifiers/HostKey.java # src/main/java/hudson/plugins/ec2/win/WinConnection.java # src/main/java/hudson/plugins/ec2/win/winrm/WinRMClient.java # src/main/resources/hudson/plugins/ec2/Messages.properties
jtnord
reviewed
Jan 23, 2025
Comment on lines
32
to
41
| try { | ||
| FIPS140Utils.ensureNoPasswordLeak(useHTTPS, password); | ||
| } catch (IllegalArgumentException e) { | ||
| throw new Descriptor.FormException(e, "password"); | ||
| } | ||
| try { | ||
| FIPS140Utils.ensureNoSelfSignedCertificate(allowSelfSignedCertificate); | ||
| } catch (IllegalArgumentException e) { | ||
| throw new Descriptor.FormException(e, "allowSelfSignedCertificate"); | ||
| } |
There was a problem hiding this comment.
There appears to be no check on the password length here if a password is in used? Also should the checks only take place if specifyPassword is true?
There was a problem hiding this comment.
Added: bac89fb (see next commit)
|
Moved to draft to avoid merging that before https://issues.jenkins.io/browse/JENKINS-75187 is fixed |
Priya-CB
approved these changes
Jan 30, 2025
jtnord
reviewed
Jan 31, 2025
Comment on lines
21
to
24
| @Test(expected = IllegalArgumentException.class) | ||
| public void testSelfSignedCertificateNotAllowed() throws MalformedURLException { | ||
| new WinRMClient(new URL("https://localhost"), "username", "password", true); | ||
| } |
There was a problem hiding this comment.
NIT, the modern way of testing an expected exception is assertThrows(Throwable.class, () -> ...)
jtnord
approved these changes
Jan 31, 2025
fcojfernandez
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to improve plugin's FIPS compliance. All the checks are centralized in
FIPS140Utilsto ensure consistency of error messages.Bump of Jenkins is required to have access to
FIPS140.useCompliantAlgorithms()Testing done
See added unit tests. Here is also screenshots from the form validation:
Submitter checklist
Link to relevant pull requests, esp. upstream and downstream changes